[tcgc] move to mutators #2305
Merged
[tcgc] move to mutators #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
iscai-msft
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
anuchandy
reviewed
Mar 4, 2025
added 10 commits
March 5, 2025 10:59
iscai-msft
force-pushed
the
tcgc/migrateToMutator
branch
from
373224a to
2b18100
Compare
timotheeguerin
approved these changes
Mar 6, 2025
tadelesh
reviewed
Mar 6, 2025
There was a problem hiding this comment.
i'm wondering if current impl could cover the real service case: https://github.com/Azure/azure-rest-api-specs/blob/13d840307175afdc951f74ffded36d5cdda2da91/specification/ai/Face/client.tsp#L59. face use another namespace to do customization. but customization namespace could only depend on one version. i'm wondering the type under that namespace could successfully mutate to old version (v1_1_preview_1).
we don't have such tests in tcgc, i believe we should add one.
packages/typespec-client-generator-core/test/types/body-model-property-types.test.ts
Outdated
Show resolved
Hide resolved
packages/typespec-client-generator-core/test/types/enum-types.test.ts
Outdated
Show resolved
Hide resolved
added 9 commits
March 6, 2025 11:45
…cgc/migrateToMutator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2215