Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typespec-autorest - remove usage of deprecated isContentTypeHeader #2335

Merged
merged 3 commits into from
Mar 7, 2025
Merged

typespec-autorest - remove usage of deprecated isContentTypeHeader #2335

merged 3 commits into from
Mar 7, 2025

Conversation

chrisradek
Copy link
Member

Similar to OpenAPI3 changes in microsoft/typespec#6311

timotheeguerin
timotheeguerin approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to update the core module here or should we rely on the dependabot one?

Just because I see pnpm-lock

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 7, 2025 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest
Show changes

@azure-tools/typespec-autorest - internal ✏️

Removes usage of isContentTypeHeader

@chrisradek
Copy link
Member Author

Did you mean to update the core module here or should we rely on the dependabot one?

Ah - I did that so that I could actually run through all the tests - can remove or use this.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 7, 2025 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website

@chrisradek chrisradek enabled auto-merge March 7, 2025 20:27
@chrisradek chrisradek added this pull request to the merge queue Mar 7, 2025
Merged via the queue into Azure:main with commit c049424 Mar 7, 2025
22 checks passed
@chrisradek chrisradek deleted the rm-is-content-type-header branch March 7, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisradek @azure-sdk @timotheeguerin