-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native auth from MSAL test app #2248
base: dev
Are you sure you want to change the base?
Conversation
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc/ @fadidurah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This app was added not for E2E tests but to let the native auth team execute (manual) release tests. We didn't automate all manual release tests in E2E, so we still need to use this application. @Yuki-YuXin can you please clarify why we're removing this app?
@nilo-ms This part of the code was created before the idea of E2E automation test was born and implemented, during that time all native auth tests relied on manual testing, so we copied a sample app with some changes and put it into the MSAL test app to make it a manual test environment. For the reason below:
If you hold another view on this, I'd be happy to bring it up as a topic in our panel discussion on Thursday. |
Introduction
Native auth adopted E2E automation test without any UI. Remove/Revert previous changes to MSAL test app.
Reference
The previous merged related PR, especially the first one.
#2001
#2143
#2118