Update IdentityCore submodule for MSIDMobileOnboardingState#3016
Open
swasti29 wants to merge 3 commits into
Open
Update IdentityCore submodule for MSIDMobileOnboardingState#3016swasti29 wants to merge 3 commits into
swasti29 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| @@ -1 +1 @@ | |||
| Subproject commit d8e80301de74108bcfa88f41e8aab428608bcfb9 | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MSAL/IdentityCore git submodule pointer so MSAL can pick up IdentityCore changes that introduce MSIDMobileOnboardingState (a reference-type wrapper used to propagate isNewMobileOnboardingFlow across recreated parameter objects).
Changes:
- Bumps the
MSAL/IdentityCoresubmodule fromd8e8030…toab0fec1…to consume the CommonCore work referenced in AzureAD/microsoft-authentication-library-common-for-objc#1868.
Review note (dependency risk):
- The target submodule SHA (
ab0fec1…) is currently the head of CommonCore PR #1868 and is not on the common repo’s default/devbranch. If that PR branch is rebased/force-pushed or deleted before merge, the SHA can become unreachable upstream andgit submodule update --init --recursivemay fail. Consider retargeting the submodule pointer to the merged commit on the common repo’s long-lived branch (or merging #1868 first, then updating the pointer here).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1cc9063 to
5aaaaca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates IdentityCore submodule to include
MSIDMobileOnboardingState— a shared reference-type wrapper forisNewMobileOnboardingFlow.Dependencies