Add generic Ephemeris implementation #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeyensj
approved these changes
Aug 1, 2024
| orbits, | ||
| observers, | ||
| lt_tol: float = 1e-12, | ||
| max_iter: int = 10, |
There was a problem hiding this comment.
I had set this to 10 just because its a nice number but feel free to change this. Our examples from yesterday seemed to complete in about 4 iterations.
There was a problem hiding this comment.
I don't really have a sense of the long tail curve for convergence (if there even is one). In my mind, it's perfectly okay if the max_iter is literally never reached, it's only there to keep something that won't converge from running on forever.
Co-authored-by: Joachim Moeyens <[email protected]>
Co-authored-by: Joachim Moeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses functions generated by @moeyensj and @KatKiker to allow any adam-core propagator the ability to generate lighttime corrected Ephemeris.