Return propagated orbits with original origins and frame based on inp… #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntellis
approved these changes
Aug 13, 2024
Comment on lines
-24
to
-30
| # Test to see that at least one impact-enabled propagator is | ||
| # installed and if not print a warning | ||
| if importlib.util.find_spec("adam_core.propagator.adam_assist") is None: | ||
| logger.warning( | ||
| "No impact-enabled propagator installed. Impact calculations will not be possible." | ||
| ) | ||
|
|
There was a problem hiding this comment.
Is it worth leaving this in in case one only has pyoorb?
There was a problem hiding this comment.
No, I decided it was better to simply error out when trying to run a propagator without the impact mixin. The warning was getting triggered inadvertently.
moeyensj
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut orbit_id
This updates the high level
.propagate_orbitsmethod to return orbits with their originalOriginandframe. Now this logic will hold for all pluggable backends for thePropagatorclass.