Upgrade to numpy>=2.0.0 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moeyensj
force-pushed
the
jm/numpy-version
branch
from
a446cef
to
d992f84
Compare
moeyensj
force-pushed
the
jm/numpy-version
branch
from
d992f84
to
627d07b
Compare
moeyensj
commented
Sep 17, 2024
Comment on lines
-29
to
-43
| cache: 'pip' # caching pip dependencies | ||
|
|
||
| - name: Install openorb dependencies | ||
| run: | | ||
| sudo apt-get update -y | ||
| sudo apt-get install -y gfortran liblapack-dev | ||
| wget -P /tmp/ https://storage.googleapis.com/oorb-data/oorb_data.tar.gz | ||
| mkdir -p /tmp/oorb/ | ||
| tar -xvf /tmp/oorb_data.tar.gz -C /tmp/oorb/ | ||
| cache: 'pip' # caching pip dependencies | ||
| - name: Install Testing Dependencies | ||
| run: | | ||
| pip install pip --upgrade | ||
| pip install ".[dev]" | ||
| # Install pyoorb propagator from source | ||
| pip install git+https://github.com/B612-Asteroid-Institute/adam-pyoorb.git@main |
There was a problem hiding this comment.
Controversial maybe but I think it is time.
|
I tested adam-assist against this version and unit and integration tests all passed. I was worried that maybe the serialization to numpy arrays in rebound might behave differently, since I think the C apis have changed, but as far as I can tell it's fine. Looks like unit tests for adam-core pass in about same amount of time (~1min 30s), so not obvious performance from that alone. adam_etl might have the biggest changes, but we were due for a big upgrade anyway. |
akoumjian
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.