Skip to content

Harden backend blog error flashes #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jynbil1 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Harden backend blog error flashes #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions backend/controllers/BlogController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ public function actionCreate()

if($response->getStatusCode() != 200) {

Yii::$app->session->addFlash("error", json_encode($response->data['message']));
Yii::warning([
'message' => 'Blog post create failed',
'status' => $response->getStatusCode(),
'provider_message' => isset($response->data['message']) ? $response->data['message'] : null,
], __METHOD__);
Yii::$app->session->addFlash("error", Yii::t('app', 'Unable to save blog post. Please try again.'));

return $this->render('create', [
"post" => $params
Expand Down Expand Up @@ -137,7 +142,13 @@ public function actionUpdate($id)
$response = Yii::$app->blogManager->updatePost($id, $params);

if($response->getStatusCode() != 200) {
Yii::$app->session->addFlash("error", json_encode($response->data['message']));
Yii::warning([
'message' => 'Blog post update failed',
'status' => $response->getStatusCode(),
'post_id' => $id,
'provider_message' => isset($response->data['message']) ? $response->data['message'] : null,
], __METHOD__);
Yii::$app->session->addFlash("error", Yii::t('app', 'Unable to save blog post. Please try again.'));
} else {
return $this->redirect(['view', 'id' => $id]);
}
Expand All @@ -160,7 +171,13 @@ public function actionDelete($id)
$response = Yii::$app->blogManager->deletePost($id);

if($response->getStatusCode() != 200) {
Yii::$app->session->addFlash("error", json_encode($response->data['message']));
Yii::warning([
'message' => 'Blog post delete failed',
'status' => $response->getStatusCode(),
'post_id' => $id,
'provider_message' => isset($response->data['message']) ? $response->data['message'] : null,
], __METHOD__);
Yii::$app->session->addFlash("error", Yii::t('app', 'Unable to delete blog post. Please try again.'));

return $this->redirect(['view', 'id' => $id]);
}
Expand All @@ -180,11 +197,9 @@ protected function findModel($id)
$response = Yii::$app->blogManager->viewPost($id);

if($response->getStatusCode() != 200 || empty($response->data['ID'])) {
// Yii::$app->session->addFlash("error", json_encode($response->data['message']));

throw new NotFoundHttpException(Yii::t('app', 'The requested page does not exist.'));
}

return $response->data;
}
}
}
18 changes: 18 additions & 0 deletions tests/check-backend-blog-error-flashes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env bash
set -euo pipefail

target="backend/controllers/BlogController.php"

grep -q "Blog post create failed" "$target"
grep -q "Blog post update failed" "$target"
grep -q "Blog post delete failed" "$target"
grep -q "Unable to save blog post. Please try again." "$target"
grep -q "Unable to delete blog post. Please try again." "$target"
grep -q "provider_message" "$target"

if grep -Fq "addFlash(\"error\", json_encode(\$response->data['message']))" "$target"; then
echo "backend blog controller still flashes raw provider messages" >&2
exit 1
fi

echo "Backend blog error flash guard passed."