Fix: Guard PermissionService context and fix template call - #108
Open
sentry[bot] wants to merge 1 commit into
Open
Fix: Guard PermissionService context and fix template call#108sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for studenthub-staff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
TypeError: Cannot read properties of undefined (reading 'companyId')occurring inPermissionService.hasPermission.The root cause was identified as
PermissionServiceattempting to accesscontext.companyIdwhen thecontextargument wasundefined. This happened becausecompany-view.page.htmlwas callinghasPermission('company-stats', 'Company')without providing the necessary context object for company-specific permissions.The fix involves a two-pronged approach:
PermissionService: Added optional chaining (context?.companyId) to line 37 ofsrc/app/providers/permission.service.ts. This ensures that ifcontextisundefined, the expression gracefully evaluates toundefinedinstead of throwing aTypeError.src/app/pages/logged-in/company/company-view/company-view.page.htmlto correctly pass thecompanyIdcontext:permissionService.hasPermission('company-stats', 'Company', { companyId: company_id }). This aligns the call with the expected signature of the service method.Fixes SH-STAFF-APP-6
Fixes TECH-2027