Repository navigation
Input type enforcement - #113
Merged
Merged
Conversation
MImran2002
requested changes
Sep 15, 2026
Gavin-Miller23
requested review from
Gavin-Miller23
and
a lite review from Copilot
and removed request for
Copilot
September 24, 2026 15:20
Contributor
|
I can submit even if i type one period after the number. Multiple periods won't work and no other symbols and spaces work, but one period gets through if there is a number beforehand. |
baobao1355
reviewed
Sep 24, 2026
| @@ -0,0 +1,6 @@ | |||
| $("#number").on("input", function(){ | |||
| if ($(this).val() && isNaN($(this).val())) { | |||
| this.setCustomValidity("Please enter numbers only."); | |||
Contributor
There was a problem hiding this comment.
I could still add a period (.) after the course number
Contributor
There was a problem hiding this comment.
@bakobagassas has this been resolved? if so I will do a final check and merge this
Contributor
Author
There was a problem hiding this comment.
Yes, the period now triggers the validity tag too and the spaces are just automatically stripped
…ty tags for others)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #104
When a user goes to Administration → Course Management and adds a new course, the course number field currently allows alphabetic characters to be entered.
Changes
Testing