Skip to content

Fixing the List of Summer Terms on the Request Summer Proposal page - #1767

Merged
MImran2002 merged 29 commits into
developmentfrom
1747_Bright_Artem
Sep 25, 2026
Merged

MImran2002 merged 29 commits into
developmentfrom
1747_Bright_Artem

Conversation

@ArtemKurasov

@ArtemKurasov ArtemKurasov commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Issue Description

Fixes issue #1747

  • If you request a summer proposal on a CCE Minor Profile page, student might not have enough Summer terms to choose from.
  • The number of summers on the list depends on the academic year of the student, the term (Fall, Spring, or Summer), and whether they graduate this term.
  • The key idea is that we should display all the summers between the start of college and the student's graduation. Also, we should not display future terms unless it comes right after the current term and the student has not been graduated by that time.

Changes

  • There are now more Summer Terms options for the CCE Minor Proposal Form for upperclassmen.
  • The options reflect the academic year of a student. For example, if they are a freshman, they will have no options (because they couldn't have any past summer experience after the start of college); if they are a junior and it's currently the spring term, they will have 3 options (because they had 2 summers after starting college + there is also a summer term coming right after the spring term).

Automatic Testing

Type pytest tests/code/test_utils.py to run all the tests for the updated logic

Manual Testing

  1. Go to Admin > Minor Management
  2. Choose different students on the CCE Minor Progress list/table
  3. Click on the Request Summer Proposal button
  4. Click on the Summer Year dropdown
  5. Make sure that the displayed years match the Student's academic year

@ArtemKurasov
ArtemKurasov marked this pull request as ready for review July 17, 2026 15:53
@brightfietsop-ux

brightfietsop-ux commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Fixes issue ##1747

Summary

Updated the CCE Minor Summer Experience form so students see summer years based on their estimated enrollment period.

What Changed

  • Added selectAllSummerTerms() to estimate a student’s admission year using:
    • Current class level
    • Current academic term
    • Graduation status
  • Limited the dropdown to summers within the student’s estimated enrollment window.
  • Included the current summer when the student is still enrolled.
  • Prevented graduated students from receiving summer options.
  • Updated dropdown options to use explicit Term IDs.
  • Removed unused or broken JavaScript references from the form.
  • Added Summer 2018–2020 to the demo/test data using non-conflicting IDs.

For example, a Senior in Summer 2021 sees Summer 2018–2021, while a Sophomore sees Summer 2020–2022.

Testing

Added tests covering:

  • Freshman, Sophomore, and Senior enrollment windows
  • Current-summer behavior
  • Graduated students
  • Missing or unrecognized class levels
  • Exclusion of summers beyond the estimated graduation window

Comment thread app/controllers/minor/routes.py Outdated
Comment thread app/controllers/minor/routes.py Outdated
Comment thread app/logic/utils.py Outdated
Comment thread app/logic/utils.py Outdated
{{ super() }}
<script type="module" src="/static/js/minorProfilePage.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery.inputmask/3.3.4/jquery.inputmask.bundle.min.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-select/1.5.4/bootstrap-select.js"></script>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these remove?

Comment thread tests/code/test_utils.py
@ArtemKurasov ArtemKurasov removed their assignment Sep 8, 2026
Comment thread app/logic/utils.py Outdated
Comment thread app/logic/utils.py Outdated
Comment thread app/templates/minor/summerExperience.html Outdated
Comment thread tests/code/test_utils.py Outdated
Comment thread tests/code/test_utils.py Outdated
@bakobagassas
bakobagassas self-requested a review September 18, 2026 15:57
Comment thread app/logic/utils.py
@github-actions

Copy link
Copy Markdown

View Code Coverage

@MImran2002 MImran2002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MImran2002
MImran2002 merged commit f9e7473 into development Sep 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants