Repository navigation
Group Bonner cohort filter with the Bonner students control - #1825
Open
Avinash-006 wants to merge 2 commits into
Open
Avinash-006 wants to merge 2 commits into
Avinash-006 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
Fixes #1816 and #1817 as one logical UI change. The cohort selector sits away from its parent category, and its All option is ambiguous.
Changes
Group the cohort selector beside the Bonner Students button. Use All Bonner cohorts for the menu option, initial selection, and restored selection. Keep the CCE category outside the Bonner group and allow categories to wrap.
Testing
node --check app/static/js/graduationManagement.jsandgit diff --checkpass.AI assistance: OpenAI Codex investigated, implemented, reviewed, and checked this change on behalf of the submitter.