change to behaviour of the ec2facts process#22
Open
freibuis wants to merge 1 commit into
Open
Conversation
Contributor
|
If you want a faster deploy time check out the branch in #21. It explicitly checks for permission and if it isn't granted does not bother retrying the query. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you add this module to a control repo. the fact will fire on all machines even if the class is not declared. at this point tje resources have not already been deployed.. example awscli and creds
this module will break nodes that are
what this pull request hopes to achieve is to
/root/.aws/.ectags_use_credentials_fileexists/root/.aws/.ec2tags_enabledfile) meaning it will not run unless this class has been declared or the admin has declared they want it.The downside to this is that facter will not get ec2_tags the first time around.
The upside is that it will deploy faster first time and no prfile cred collisons