[pull] dev from KelvinTegelaar:dev #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: hashtable alert errors for CIPPAlertOneDriveQuota
Templates with tenant filters that resolve to no tenants (empty groups) are now skipped instead of being assigned an empty tenant list. This prevents unnecessary processing of templates that do not apply to any tenants.
Bug: Handle array type for conditions.users in Conditional Access Template processing
Check accountEnabled property for shared mailbox user
Replaces direct property assignment with Add-Member for 'DynamicRules' to ensure consistency with other property additions in the group entity.
adds the description (displayName) and secret ID to the table for easier identification / automation.
Replaced the loop generating multiple partition key filters with a single filter using 'PartitionKey ge' and 'PartitionKey le' for date ranges. This streamlines the query and improves readability.
Added explicit checks to ensure $Tenant and $StandardKey are not null or empty before accessing or modifying related data structures. This improves robustness and prevents potential runtime errors.
Update template update checks to ensure the source matches the current template repository before updating or skipping. Also, add the -Compress flag to ConvertTo-Json calls to reduce JSON size when storing entities.
The Source property is now included when creating the entity for Add-CIPPAzDataTableEntity, using the value from $Template.Source if available.
Introduces a -SkipCache switch to Get-TenantGroups and updates Invoke-ListTenantGroups to use it, allowing cache bypass for fresh data retrieval. Also improves Update-CIPPDynamicTenantGroups to handle multiple referenced tenant group IDs for 'in' and 'notin' operators, aggregating member IDs across groups.
Introduces IP range management for both custom and default roles, storing allowed IPs in a dedicated table. Updates role creation, cloning, deletion, and listing to handle IP ranges, and enforces IP-based access restrictions in Test-CIPPAccess. Superadmin roles are exempt from IP restrictions to prevent lockout.
Feat: Add standard to enable windows diagnostic data settings in Intune
Removed eager loading of direct tenant secrets in Get-CIPPAuthentication and implemented lazy loading in Get-GraphToken. This change improves performance by only fetching secrets from storage or Key Vault when needed, rather than at authentication initialization.
Updated Push-CIPPTest to return @{ testRun = $false } when a test function is not found or an exception occurs, providing clearer feedback on test execution status.
…agation time for larger batches.
Changed API log identifiers to 'NewTenant' in Push-ExecOnboardTenantQueue.ps1 and Invoke-ExecAddTenant.ps1 for consistency and improved log tracking when onboarding or adding new tenants. fixes KelvinTegelaar/CIPP#5278
Move test enumeration out of Invoke-CIPPDBTestsRun into a new Push-CIPPTestsList activity. Invoke-CIPPDBTestsRun now builds a batch of per-tenant CIPPTestsList activities and starts a 'TestsList' orchestrator, simplifying orchestration responsibility. Added Push-CIPPTestsList which enumerates Invoke-CippTest* functions, verifies tenant DB data, builds per-tenant test batches, and starts a per-tenant 'TestsRun_{Tenant}' orchestrator. Also updated logging/messages to reflect the new flow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.2)
Can you help keep this open source service alive? 💖 Please sponsor : )