Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Existing MRU Computers when Saving #6110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ChihweiLHBird
Copy link

@ChihweiLHBird ChihweiLHBird commented Feb 23, 2025

Fix: #6112
This is to fix an issue causing duplicated or lost of MRU computers when multiple windows (instances) of BOINC manager are saving the MRU list into the state.

@ChihweiLHBird ChihweiLHBird changed the title Merge the MRU computers list when saving Merge the MRU computers list with exitsting state when saving it into the state Feb 23, 2025
@AenBleidd AenBleidd added this to the Client/Manager 8.2.0 milestone Feb 23, 2025
@ChihweiLHBird ChihweiLHBird changed the title Merge the MRU computers list with exitsting state when saving it into the state Preserve Existing MRU Computers when Saving Feb 23, 2025
@ChihweiLHBird ChihweiLHBird marked this pull request as ready for review February 26, 2025 03:14
@AenBleidd AenBleidd requested a review from Copilot February 26, 2025 08:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ChihweiLHBird
Copy link
Author

Hi @AenBleidd, any idea about adding tests for this change? I took a look but didn't find a good point for adding test for this functionality of BOINC Manager.

@AenBleidd
Copy link
Member

We don't have tests for that, so I'll test that manually.

@AenBleidd AenBleidd self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Duplicated or lost hostname in the most recently use remote computers list in BOINC manager
2 participants