Skip to content

fix(ui): daily cost trend chart not rendering bars #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
May 20, 2026
Merged

fix(ui): daily cost trend chart not rendering bars #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/gateway/src/cost-tracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ export function computeDailyCosts(days = 14, preloaded?: HistoricalEstimates): D
buckets.set(d.toISOString().slice(0, 10), { cost: 0, sessions: 0 });
}

// Historical sessions
// Historical sessions (excludes currently-live sessions)
const hist = preloaded ?? computeHistoricalEstimates();
for (const s of hist.sessions) {
if (s.lastMessage < cutoffMs) continue;
Expand All @@ -864,13 +864,18 @@ export function computeDailyCosts(days = 14, preloaded?: HistoricalEstimates): D
bucket.sessions += 1;
}

// Live sessions (bucket to today)
// Live sessions — bucket by today's date. Historical estimates skip live
// sessions (to avoid double-counting), so we must add them here. We bucket
// to today since these sessions are actively accumulating cost right now.
const todayKey = today.toISOString().slice(0, 10);
const todayBucket = buckets.get(todayKey);
if (todayBucket) {
for (const [, c] of sessions) {
todayBucket.cost += totalActualCost(c);
todayBucket.sessions += 1;
const cost = totalActualCost(c);
if (cost > 0) {
todayBucket.cost += cost;
todayBucket.sessions += 1;
}
}
}

Expand Down
14 changes: 8 additions & 6 deletions packages/gateway/src/ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,20 +479,21 @@ form.inline { display: inline; }
/* --- Daily cost trend chart --- */
.daily-chart {
display: flex; align-items: flex-end; gap: 3px;
height: 100px; padding: 8px 0; margin: 12px 0;
height: 120px; padding: 8px 0; margin: 12px 0;
border-bottom: 1px solid var(--border);
}
.day-col {
flex: 1; display: flex; flex-direction: column;
align-items: center; min-width: 0;
align-items: center; justify-content: flex-end;
min-width: 0; height: 100%;
}
.day-bar {
width: 100%; background: #60a5fa; border-radius: 2px 2px 0 0;
min-height: 2px;
min-height: 2px; flex-shrink: 0;
}
.day-label {
font-size: 0.65em; color: var(--fg3); margin-top: 4px;
white-space: nowrap; overflow: hidden;
white-space: nowrap; overflow: hidden; flex-shrink: 0;
}
.actions { margin: 16px 0; display: flex; gap: 8px; }
.empty { color: var(--fg3); font-style: italic; padding: 24px 0; text-align: center; }
Expand Down Expand Up @@ -2120,12 +2121,13 @@ function pageCosts(): string {
if (dailyCosts.some((d) => d.cost > 0)) {
body += `<h3>Daily Cost Trend (last 14 days)</h3>`;
body += `<div class="daily-chart">`;
const barMaxPx = 90; // max bar height in pixels (leaves room for label)
for (const day of dailyCosts) {
const heightPct = (day.cost / maxDayCost) * 100;
const barPx = Math.max(2, (day.cost / maxDayCost) * barMaxPx);
const label = day.date.slice(5); // "MM-DD"
const tooltip = `${day.date}: ${formatUSD(day.cost)} (${day.sessions} session${day.sessions !== 1 ? "s" : ""})`;
body += `<div class="day-col" title="${esc(tooltip)}">
<div class="day-bar" style="height:${heightPct.toFixed(1)}%"></div>
<div class="day-bar" style="height:${barPx.toFixed(0)}px"></div>
<div class="day-label">${esc(label)}</div>
</div>`;
}
Expand Down
Loading