Fix audit instructions: CPN status, function name, numbering#38
Merged
Conversation
- CPN revnet is actively deployed via _deployCpnRevnet(), not commented out. Remove incorrect "TODO -- currently commented out" claim. - Fix allowSuckerDeployers -> allowSuckerDeployer (singular, called in loop). - Fix duplicate numbering in deployment phases list (two items numbered 6, two numbered 7). Renumber 6-14 and fix phase label 03d -> 03f for Cross-Chain Suckers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_deployCpnRevnet()is actively called in Phase 08 (verified in Deploy.s.sol line 394).allowSuckerDeployers(plural) toallowSuckerDeployer(singular) -- the function is called in a loop per deployer.Test plan
grep -n "_deployCpnRevnet" script/Deploy.s.solconfirms active call at line 394grep "allowSuckerDeployer" script/Deploy.s.solconfirms singular function name🤖 Generated with Claude Code