Skip to content

Fix USER_JOURNEYS.md accuracy issues#39

Merged
mejango merged 1 commit intomainfrom
docs/user-journeys-quality-pass-3
Mar 23, 2026
Merged

Fix USER_JOURNEYS.md accuracy issues#39
mejango merged 1 commit intomainfrom
docs/user-journeys-quality-pass-3

Conversation

@mejango
Copy link
Contributor

@mejango mejango commented Mar 23, 2026

Summary

  • Fixed self-contradictory phase statement: only phases 01, 02, 03a, 03b, 03e, 04 are pure CREATE2
  • Added 3 missing fork test files (PayoutReentrancy, ReservedInflation, SuckerBuyback)
  • Added error parameters to JBChainlinkV3PriceFeed_StalePrice(timestamp, threshold, updatedAt)
  • Fixed OP Sepolia skip: caused by block.chainid check, not _positionManager == address(0)

Test plan

  • Verify each fix against source code line references
  • No code changes, documentation only

🤖 Generated with Claude Code

Every claim in USER_JOURNEYS.md was verified line-by-line against the
source code. This commit fixes all confirmed inaccuracies: stale function
names, incorrect conditions, missing events/errors, and misleading
descriptions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mejango mejango merged commit ecff2a3 into main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant