fix: address audit findings H-8, H-9, M-11#42
Merged
Conversation
H-8: Deploy JBSuckerRegistry before singleton sucker implementations so clones receive a non-zero registry immutable. H-9: Guard revnet, CPN, NANA, and Banny deployment when buyback registry is unset (Uniswap stack skipped). M-11: Verify deployer owns the project in _ensureProjectExists before reusing an existing project ID. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_deploySuckersto deployJBSuckerRegistrybefore singleton sucker implementations, preventing clones from receiving a zero-address registry immutable._deployRevnet,_deployCpnRevnet,_deployNanaRevnet, and_deployBannywith an early return when_buybackRegistryis unset (Uniswap stack skipped), preventing revnets from consuming zero-address registries._ensureProjectExists— revert withDeploy_ProjectNotOwnedif the deployer does not own the existing project.Test plan
forge buildcompiles successfully_ensureProjectExistsreverts when the deployer is not the project owner🤖 Generated with Claude Code