Refactor into subpackage to allow importing#1
Open
elmeyer wants to merge 3 commits intoBarrixar:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you very much for this well-designed, useful and not least extremely comprehensive package!
I am opening this pull request to allow this package to be imported in and used by other Go packages. To this end, I added a
go.mod+go.sumto this package. Otherwise (thankfully), the exported functions for verification were already perfectly suitable for this, so only minimal adjustments were required.I simply split and renamed the functions responsible for determining the Windows version into a subpackage named
winver, purely for semantic reasons, and moved most of the remaining code into theverifysubpackage. No other changes were made.Please let me know if I missed something or if you'd like to see any changes. I look forward to your feedback!
Should you decide to accept this pull request, please remember to remove the
replacedirective ingo.modwhen merging.