-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation when create/update App #2020
Conversation
@beastoin pls help me to review |
1/ learn about the pydantic model then apply it. |
1d99006
to
c871d2c
Compare
1/ attempted to apply pydantic. pls help me to review again @beastoin |
1/ ok |
2/ i defined list restricted fields to prevent user from update this @beastoin |
2/ use whitelist instead of blacklist. we should have the allowed fields for creation as well. @nquang29 last commit please 😌 |
2/ done sir @beastoin . but i think we should separate model to AppUpdate, AppCreate for api create/update |
2/ separating the model, do it pls @nquang29 |
2/ done sir @beastoin |
lgtm @nquang29 🌚 Next, let's make the model a bit more generic and share your test with our app (in dev env). |
#2011