Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Macos Platform support #2045

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cscoderr
Copy link
Contributor

@cscoderr cscoderr commented Mar 17, 2025

This PR resolve #2010

Add Macos Platform support

This PR introduces macOS platform support for the Omi app, enabling it to run as a standalone macOS application. Additionally, it includes functionality for recording audio on macOS.

Key Features

  • Added macOS platform support, allowing the app to function as a native macOS application.
  • Implemented a macOS flavor(dev, prod) for better platform-specific handling.
  • Introduced flags to exclude packages that lack macOS compatibility (Still in progress).
  • Enabled audio recording functionality on macOS.

A detailed video demonstration is provided below.

https://github.com/user-attachments/assets/ced4509d-3233-481b-8415-3717f61e574b
/claim #2010

@algora-pbc algora-pbc bot mentioned this pull request Mar 17, 2025
2 tasks
Copy link

algora-pbc bot commented Mar 17, 2025

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@cscoderr
Copy link
Contributor Author

@mdmohsin7 @kodjima33 can you help review this

@beastoin
Copy link
Collaborator

  1. Clean your code first; keep changes minimal.
  2. If-else without a systematic way is a bad idea. Read more about my suggestion for the similar ticket at add basic web support #2014 (comment).
  3. You should put the system mic into the service initial function; no new variable needed. We've already achieved that level of abstraction; don't waste it.

But please ask the stakeholder about the needs or clarify about it, e.g. run an iOS version on Mac or run a dedicated Mac app.

@cscoderr

@beastoin beastoin marked this pull request as draft March 24, 2025 03:56
@cscoderr
Copy link
Contributor Author

@beastoin Thank you for your feedback

Okay, I’ll work on it.
I’ll check it out and make the necessary updates.
The reason for creating a separate service is because the current one is integrated with a background service, and the package it uses doesn’t support macOS.
I’ve worked on the PR based on the issue. How should I approach the stakeholder for feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make omi work on macOS
2 participants