feat: Add NFC Support #568 #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I have ordered an NFC antenna, ill wire it up and test the nfc properly. Then see if it can be made to work without (if possible). I cant close this PR untill some hardware testing is done. My hunch is the antenna is a requirementSent from my iPhoneOn 25 Aug 2024, at 07:54, Nik Shevchenko ***@***.***> wrote:
@vincentkoc
how can I test this?
So it wouldn't work without antennas
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
josancamon19
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial resolution to #568 - My thinking is we can use "app links" in flutter for Google and iOS based on the friend website. This is how airtags etc all work, it also means you can do a "found" or setup instructions if it dose not go to the site. Issue is there is no NFC antenna on V1 or V2, so I will solder one on once Im back in Sydney or someone has one to test they can give this a spin.
Once reviewed I can close out the additional changes.