a fix for #2261

[seefood]

this should fix #2261 without breaking any existing value of $LESS

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• I have added tests to cover my changes, and all the new and existing tests pass.

[seefood]

@bmjsmith can you test if this fixes you up?

[seefood]

@akinomyoga anything missed here?

[akinomyoga]

I'm not sure if the design of setting those environment variables globally would make sense in the first place because it would affect the normal call of less and other applications internally using less to show information (such as git). One can consider setting these environment variables only for man using env as the corresponding ohmyzsh plugin (ohmyzsh/colored-man-pages) does. Or one can consider setting the environment variables locally in a shell function that calls man as the corresponding oh-my-bash plugin does.

That said, that's not this PR's business. I think the fix in this PR is just fine after addressing the following one point. This should be merged after that.

[bmjsmith]

@bmjsmith can you test if this fixes you up?

Thank you, yes this works fine.