Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aws_profile in base theme to work with new aws cli versions #2290

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mdaydevelopment
Copy link
Contributor

Description

aws cli version 2 changed the variable used to override the default profile from AWS_DEFAULT_PROFILE to AWS_PROFILE. This pr updates the aws_profile function in the base theme to work with the new variable, but will still fall back to the old one if the new one is unset.

Motivation and Context

Custom themes using this function are useful for people who manage multiple AWS accounts. This will allow them to continue working with new versions of aws cli moving forward.

How Has This Been Tested?

Tested with either and both variable in multiple themes on multiple machines and none of them caught fire. The change maintains backward compatibility, so the only people who could theoretically be impacted are those still using and old version of aws cli for some reason and also coincidentally setting AWS_PROFILE for some other purpose.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [na] If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [na] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • [na] I have added tests to cover my changes, and all the new and existing tests pass.

@seefood seefood self-assigned this Feb 19, 2025
Copy link
Contributor

@seefood seefood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

@seefood seefood merged commit 5797ad3 into Bash-it:master Feb 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants