Skip to content

Move four dependencies past their security advisories (Closes #410) - #428

Merged
BattermanZ merged 1 commit into
devfrom
fix/410-audit
Oct 23, 2026
Merged

BattermanZ merged 1 commit into
devfrom
fix/410-audit

Conversation

@BattermanZ

Copy link
Copy Markdown
Member

Summary

Each advisory is fixed by a patch release inside the versions already in use. Nothing goes into deny.toml or ui/npm-audit-exceptions.json.

 Cargo.lock (ships in the binary)
-rustls-webpki      0.103.15   RUSTSEC-2026-0382
+rustls-webpki      0.103.16
-webpki-root-certs  1.0.9      RUSTSEC-2026-0383
+webpki-root-certs  1.0.10
-webpki-roots       1.0.9      RUSTSEC-2026-0381
+webpki-roots       1.0.10
 tempfile -> getrandom 0.4.3 becomes 0.3.4 (both already in the tree, tempfile takes either)

 ui/ (dev dependencies, nothing ships)
-vite    8.2.2    GHSA-587h-7wmj-h5pm (high) + 2 moderate, 2 more moderate, 1 low
+vite    8.2.4    the 8.2 line's fix; 8.3 not taken
-vitest  4.1.11   GHSA-qxg6-89mg-rqv8, GHSA-xp26-3454-mjgp (published after #410)
+vitest  4.1.12   chai and tinyrainbow move with it

npm install raised the floors in ui/package.json to ^8.2.4 and ^4.1.12. The low cookie advisory under SvelteKit stays below the bar, as the audit recipe's comment explains. No changelog line, because a cook sees nothing different.

Evidence

  • Before: just audit fails. cargo-deny names the three RUSTSEC advisories, and npm audit fails on vite: launch-editor (high).
    After: just audit prints both dependency trees are clean at the levels this gate enforces.
  • just check passes. just test passes: every Rust suite, plus 1379 screen tests in 68 files.
  • Live, on the dev instance restarted on this branch:
    • The screens load through vite 8.2.4 at every size (just screens, no console error).
    • import_web_link on a BBC Good Food recipe completed, with the page and its photograph fetched over HTTPS through the new rustls-webpki. The test recipe was deleted afterwards.
  • Lockfile integrity: the npm integrity fields equal npm view <pkg> dist.integrity for vite, vitest, chai and tinyrainbow, and cargo fetch --locked passes.

Merge Danger

Door: two-way

Reverting the commit puts the old lockfiles back.

Blast Radius: outbound-TLS

A site whose certificate chain runs through the distrusted emSign intermediates now fails to import from a link. That is the fix doing its job. The vite and vitest moves touch development and tests only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01126KLKw9pGwH2vG3r1i2VL

`just audit` failed on dev in both trees. Each advisory is fixed by a
patch release inside the versions already in use, so nothing is excused.

Rust, Cargo.lock only:
- rustls-webpki 0.103.15 -> 0.103.16 (RUSTSEC-2026-0382)
- webpki-root-certs 1.0.9 -> 1.0.10 (RUSTSEC-2026-0383)
- webpki-roots 1.0.9 -> 1.0.10 (RUSTSEC-2026-0381)
The targeted update also re-pointed tempfile from getrandom 0.4.3 to
0.3.4. tempfile accepts both and both were already in the tree.

The interface, dev dependencies only:
- vite 8.2.2 -> 8.2.4: the launch-editor high (GHSA-587h-7wmj-h5pm) and
  the moderates and low on vite's dev server. 8.2.4 is the 8.2 line's
  fix; 8.3 was not taken.
- vitest 4.1.11 -> 4.1.12: two @vitest/mocker moderates published after
  the ticket (GHSA-qxg6-89mg-rqv8, GHSA-xp26-3454-mjgp). chai and
  tinyrainbow moved with it.
npm raised the floors in package.json so a fresh resolve can't land
below the fix. The low cookie advisory under SvelteKit stays below the
bar, as the audit recipe's comment already explains.

No changelog line: a cook sees nothing different.

Closes #410

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01126KLKw9pGwH2vG3r1i2VL
@BattermanZ
BattermanZ merged commit df8b9dd into dev Oct 23, 2026
2 checks passed
@BattermanZ
BattermanZ deleted the fix/410-audit branch October 23, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant