Repository navigation
A Demo offers no library and no install card (Closes #426) - #429
Merged
Merged
Conversation
… by itself A first-time visitor to a Demo saw "Your library isn't on this phone yet" above the welcome card, offering to download a library that goes back every morning. Option 1 was chosen for both cards: in a Demo neither the library card nor "Keep Kamosu on your phone" is drawn on any screen, and the phone copies nothing on its own, on wifi or as a top-up after a fill asked for in Settings. Settings still offers both, as on any instance. The cards ask whether the instance is a Demo before looking at the library, since a first arrival has no hint on the device and a fill started meanwhile would not stop, and draw nothing below the offline and insecure cards until the answer is in. Closes #426 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01126KLKw9pGwH2vG3r1i2VL
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Option 1, chosen for both cards: in a Demo, neither "Your library isn't on this phone yet" nor "Keep Kamosu on your phone" is drawn, on any screen, and nothing is copied onto the phone unasked. Settings › This device still offers both.
Evidence
After: live, on the same throwaway Demo built from this branch, at phone, phone-on-wifi and MacBook sizes, the top of the page was sampled every 100 ms from first arrival through a recipe, Got it and Recipes. No card was ever drawn. The only
get_recipewas opening a recipe page, even with wifi reported. Settings offered Fetch it now, and its fill showed no card at the top. A reload after it copied nothing (0 newget_recipe), and offline still said "You're offline". The dev instance, which is no Demo, still shows the library card, then the install card after "When I'm on wifi".notices.svelte.spec.ts. They cover no library card, no fill on wifi on a first arrival, no top-up after a Settings fill, no install card even before the Demo answer, and still offline. Each guard was broken in turn and its test went red.just checkandjust testpass.Merge Danger
Door: two-way
Blast Radius: small
An ordinary instance now waits for one
instance_statusanswer before the library is looked at and before the library or install card can show. The card is the same, it just appears a round trip later.🤖 Generated with Claude Code
https://claude.ai/code/session_01126KLKw9pGwH2vG3r1i2VL