[Draft] Add Revoke Permissions RPC Method #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icter comparative matcher (MetaMask#12908)
The Jest storybook config was mistakenly set to overwrite the coverage report for our main set of Jest tests. It also had extremely high coverage thresholds set, and the `collectCoverageFrom` config was asking Jest to check that the storybook tests cover all of the UI code. For now the `collectCoverageFrom` config has been removed. I don't understand why we'd want to use Storybook to unit test in the first place, so I don't understand what parts of the codebase we'd want to cover with these tests. So for the moment, only the files touched by the current tests are considered. The coverage output directory is now set to `jest-coverage/storybook` so that it does not overlap with any other coverage reports.
…ask#12792) * Send all swaps requests to api2, remove useNewSwapsApi boolean * Switch token bucket priority * Fix tests * Trigger Build * Trigger Build
* add openSeaEnabled preference * cleanup * add description copy
Version v10.7.0 RC
* Wiring up Collectibles lists/items * wip * more wip * more more wip * yet more wip * wippp * more wipppp * closer * wroking * more wip * cleanup * cleanup * add-collectible form validation * update default ipfs-gateway * update refresh button * fix proptypes issue + add more padding to asset background * css tweaking * more cleanup * more cleanup * more cleanup * add migration * address feedback * fix migration + cleanup * bumping controllers version + adapting new collectiblesController shape * fix yarn dedupe
* Trigger Build * Trigger Build * Move swaps index variables to redux * all optimizations so far * Add better equality checks for selectors in swaps index and build quote * Clean up PR, remove extra code and logs * Clean up lavamoat file * Fixes for optimizations * Update tests and test snapshots * Remove unnecessary tests * Remove unnecessary console log * Trigger Build * Trigger Build * Add delay to account for remote call made by trezor keyring Co-authored-by: Dan Miller <[email protected]>
* Added Flask Experimental Area warning to OnboardingV2 * Added first time flow Flask Experimental Area warning * Made both onboarding flows use one Experimental Area component * Fix comments in React divs * Fix unreachable code * Fix build lint problems * Changes after code review * Added guards around route constants imports * Code Review changes * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * Code review changes * Fix lint * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * Update ui/components/app/flask/experimental-area/index.scss Co-authored-by: George Marshall <[email protected]> * fix lint Co-authored-by: George Marshall <[email protected]>
Sync develop with master
* integration for tx decoding confirmation and history view * upgrading @truffle/decoder to latest release 5.1.0 * Update acorn and colors patches * feat: remove redundant styling * feat: basic integration for nickname components * feat: wiring functionality of adding new nickname * feat: wire functionality of showing nickname modal * feat: link the nickname popover with add/update popover * feat: moving forward with address nicknames integration * feat: fixing a bug related to passing chainId in addressBook * feat: populating memo prop in addressbook entry * feat: add explorer link * feat: bug fixing update nickname component * feat: fix proptypes * feat: adding tooltip for copying nickname address * featL fix styling for tx-details page * feat: optimize code for error handling * feat: limiting transaction decoding to tx with data * feat: remove tree UI component * feat: adding request to check for tx decoding supported networks * feat: showing data hex component * feat: fix react warnings * feat: remove extra margin in tx decoding * Remove unused package @truffle/source-map-utils * Ensure messages get translated * feat: link tx-decoding addresses with nicknames * Omit value for boolean attributes * Fix props reading in CopyRawData * fix: fixing issue with transaltion * Fix lint errors in TransactionDecoding - Remove unused import - Reorder imports - Address conflict between caught `error` and error state flag by renaming state flag to `hasError` - Fix requestUrl identifier casing and use of template string - Ensure `useEffect` gets passed the deps it needs - Add scope braces around case statement where it's needed - Omit literal `true` for boolean jsx attribute - Refactor nested ternary as `if` statements * fix: revert fetchWithCache modifications * Fix linting for TransactionListItemDetails - Remove unused import - Fix import spacing - Remove unused prop dereference - Fix string interpolation for translated From/To * Moving to popover pattern * fix: sass color variable * Omit value for boolean attribute * Remove changes from modal.js * fix: refactor nickname popovers * Ensure const gets declared before it's used * Fix linting for ConfirmTransactionBase - Remove unused prop chainId - Stop destructuring an unused field * fix: refactor usage of nicknames popovers in send-content-container * fix: remove extra prop updateAccountNicknameModal * fix: refactor code for address.component * fix: remove extra tooltip * Ensure NicknamePopovers always returns component * Fix linting for NicknamePopover component - Fix useCallback deps - Switch ternary to logical-or * Fix linting for SenderToRecipient ... by fixing import order * Remove unused addressCopied state * Delete empty file * fix: remove sender-to-recipient.container * fix: refactor usage of nickname popovers in confirm-page-container * fix: bug related to state variable * Stylelint fix * Lint fix * Change "Total Amount" to "Total" * Lint fix locales * Update address-book.spec.js * e2e test update * Update e2e tests * Fix issue where absence of function params in data hex tab would result in rendering a string * Fix border radius, and width and height in small notification windows, of the update-nickname-popover * Remove fake await * Clean up * Clean up Co-authored-by: Alaa Hadad <[email protected]> Co-authored-by: Dan Miller <[email protected]> Co-authored-by: g. nicholas d'andrea <[email protected]>
The calls to the background in `actions.js` that relate to the custom nonce feature now use `async/await` and `promisifiedBackground`. The behaviour should be unchanged except that when setting the nonce field, the warning is shown in case of error before the loading indicator drops, which seems like it would be a minor improvement (if it has any user-facing impact at all).
The coverage reporter for the console has been changed from `text` to `text-summary` because `text` was too long. It exceeded the maximum length of the CircleCI terminal output shown on their jobs page, making it very difficult to see why the unit test coverage job failed. The text summary only displays overall coverage metrics, but that is usually enough to indicate when the test fails due to a drop in coverage. The more detailed breakdown is still available as a HTML report linked in the `metamaskbot` comment, and in the `jest-coverage` directory when run locally. The three on-disk coverage reports used previously (`lcov`, `json`, and `clover`) have been replaced with just `html`. The HTML report was part of the `lcov` report, and it was the only one we were using.
* Organizing storybook to echo app folder structure * Updating new stories to follow new convention from develop
* parent d89e533 author georgewrmarshall <[email protected]> 1636692862 -0800 committer hmalik88 <[email protected]> 1637342043 -0500 Initial SnapSettingsCard component Updates to styles but having specificity issues so increased specificity Updates to styles but having specificity issues so increased specificity added overflow fix and added tests lockfile update prettier fix added stylelint ignore yarn.lock fixed * merge conflict fix * package/yarn fix * fixed package.json * updated lockfile... * removed comment * removed unnecessary key/val for chip status indicator color * bumped lattice to 0.4.0 in package json, fixed yarn lock * removed dupe entry in yarn lock * ran yarn setup to update lock file * updated chip label prop * parent d89e533 author georgewrmarshall <[email protected]> 1636692862 -0800 committer hmalik88 <[email protected]> 1637342043 -0500 Initial SnapSettingsCard component Updates to styles but having specificity issues so increased specificity Updates to styles but having specificity issues so increased specificity added overflow fix and added tests lockfile update prettier fix added stylelint ignore yarn.lock fixed * merge conflict fix * package/yarn fix * fixed package.json * updated lockfile... * removed comment * bumped lattice to 0.4.0 in package json, fixed yarn lock * removed dupe entry in yarn lock * ran yarn setup to update lock file * Using IconWithFallback instead of SiteIcon, fixing icon prop, and adding status story and docs page * Updating to follow storybook folder convention * Updates to styles * Adding localization * added todo comment Co-authored-by: hmalik88 <[email protected]>
* added npm icon * added snaps-authorship-pill component and story * updated npm icon * added classname * added comments * changed label to an h7 * updated default label, removed unnecessary font-weight prop * moved npm icon to flask/icons and added storybook file * added hover/focus logic * updated hover logic * updated hover logic * added authorship pill scss to app-components, removed unnecessary handlers * removed npm icon, added font-awesome icon, added font-awesome brands to scss imports * removed icons directory, updated scss file to use the proper color for npm icon, updated component with correct size and added class to change color * fixed linter errors * added link to pill and its story, changed title of story * changed link to open in new tab, moved classname to root element and made it inline-block * fixed proptype comment * fixed linter error
This reverts commit 81ea24f.
This reverts commit 81ea24f.
* conversion date fix * update in settings conversion date - no internet * update conversionDate fetch - setting container * no currency date message updated
* Adding branding and updating styles for storybook docs * Making code blocks light gray
This resolution was used to force a transitive dependency to be updated to a specific version. But this target version was within the range that was already requested, so a resolution is not needed. Yarn resolutions are used for forcing a package to update to something _outside_ of the requested range. For in-range updates, a Yarn lockfile update is all we need, and it leaves us with less of a maintenance burden (the resolution can clobber future updates).
* Improve first time flow css - select action * Update ui/pages/first-time-flow/select-action/index.scss Co-authored-by: George Marshall <[email protected]> * Update ui/pages/first-time-flow/select-action/index.scss Co-authored-by: George Marshall <[email protected]> Co-authored-by: George Marshall <[email protected]> Co-authored-by: Elliot Winkler <[email protected]>
…taMask#13220) Convert Typography story in ui/components/ui/typography/typography.stories.js to use controls argType annotation - Add README.MDX - Story has argTypes that align with component api / props - All instances of @storybook/addon-knobs have been removed in favour of control args - All instances of @storybook/addon-actions have been removed in favour of action argType annotation
Use `secrets.METAMASKBOT_CROWDIN_TOKEN` for `GITHUB_TOKEN` ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow > When you use the repository's GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.
This commit fixes a few issues with ConfirmPageContainerSummary (which holds the contract being used or action being performed and the money being sent): * Remove fixed height so that the secondary currency doesn't get cut off or spill over * Add missing padding * Fix font size of primary and secondary currencies * Add top border when there is a "address not in your address book" alert at the top Co-authored-by: Ariella <[email protected]>
… actions to controls / args (MetaMask#13230) * SendHeader, ContactListTab and AdvancedTab story: converted knobs and actions to controls / args * Added the other function type props to action controls * Requested review changes
Co-authored-by: caogu <[email protected]>
…taMask#13189) Co-authored-by: George Marshall <[email protected]>
…pover even if dapp has no gas suggestion (MetaMask#13316)
…o add an NFT on the Import Token page (MetaMask#13271) * Add error that redirects users to Import NFT page when they attempt to add an NFT on the Import Token page
* Add modal pop for NFTs previously added as tokens - with directions to re-add as NFTs
…Mask#13344) * base-styles.scss: update a:hover to --Blue-400 - deprecates #df6b0e * preserve a.warning:hover orange color w/ #ceafa22 * Revert "preserve a.warning:hover orange color w/ #ceafa22" This reverts commit d0efb92. * create-account: rm .warning style from help link - supports #ceafa2
… between settings (MetaMask#12813)
* remove ganache-core * use ganache v7 * convert to hex * lint
* NFT UX cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
Explanation:
Manual testing steps: