Add database connection check to install and update tasks - #445
Merged
Conversation
ddon
added a commit
that referenced
this pull request
Mar 23, 2026
…m status task - Rename check?/check! to connected?/ensure_connected! for idiomatic Elixir naming - Fix @SPEC from no_return() to :ok | no_return() (function does return on success) - Return explicit :ok instead of nil on happy path - Use Mix.env() in error message instead of hardcoded config/dev.exs - Add timeout: 5_000 to SELECT 1 query to prevent hangs - Remove DbConnectionCheck from status task — it already handles DB failures gracefully via get_database_status/1 and shows "Connection failed" in the status tree; the hard exit was preventing status from doing its job - Add PR review docs for #445 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.