Skip to content

Extract Emails module to standalone package #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddon merged 12 commits into from
Mar 23, 2026
Merged

Extract Emails module to standalone package #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7b0ef6
Add lastmod to sitemap group listings and homepage
timujinne Mar 18, 2026
072fd0e
Merge remote-tracking branch 'upstream/dev' into dev
timujinne Mar 19, 2026
d20da8c
Add email provider behaviour, refactor Mailer and UserNotifier
timujinne Mar 19, 2026
af6af2e
Add AdminEditHelper for universal admin edit links in public views
timujinne Mar 19, 2026
0d45a28
Remove Emails module from core, extract to phoenix_kit_emails package
timujinne Mar 20, 2026
0451081
Fix cookie consent: dynamic legal links, theme-aware backdrop, daisyU…
timujinne Mar 20, 2026
1e03f22
Remove hardcoded Emails block from Modules page — now rendered as ext…
timujinne Mar 20, 2026
e3b8cf0
Enrich external module cards with config stats, settings link, and mo…
timujinne Mar 21, 2026
a1f3996
Fix module_card to render hero-* icons properly
timujinne Mar 23, 2026
6b43427
Merge remote-tracking branch 'upstream/dev' into dev
timujinne Mar 23, 2026
545b0e7
Fix external_plugin_view? to recognize PhoenixKit.Modules.*.Web as ex…
timujinne Mar 23, 2026
4c38e91
Fix extract_admin_links: skip parent tabs, deduplicate paths
timujinne Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 7 additions & 38 deletions .dialyzer_ignore.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,68 +12,31 @@
{"lib/phoenix_kit/install/migration_strategy.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.status.ex", :unknown_function},
{"lib/phoenix_kit/migrations/postgres.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/email_cleanup.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/email_export.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/email_stats.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/email_test_webhook.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/email_verify_config.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/entities/export.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit/entities/import.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.email.debug_sqs.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.email.process_dlq.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.email.send_test.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.configure_aws_ses.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.process_dlq.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.process_sqs_queue.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.sync_email_status.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.seed_templates.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.fix_missing_events.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.process_sqs.ex", :unknown_function},
{"lib/mix/tasks/phoenix_kit.cleanup_orphaned_files.ex", :unknown_function},

# Mix.Task behaviour callbacks (expected in Mix tasks)
# Note: Mix.Task behaviour info is not available to Dialyzer (compile-time only)
# Adding @impl Mix.Task does not fix this warning
{"lib/mix/tasks/phoenix_kit.doctor.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.gen.migration.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.seed_templates.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.install.ex", :callback_info_missing, 2},
{"lib/mix/tasks/phoenix_kit.update.ex", :callback_info_missing, 3},
{"lib/mix/tasks/phoenix_kit.gen.admin_page.ex", :callback_info_missing},
{"lib/mix/tasks/phoenix_kit.gen.dashboard_tab.ex", :callback_info_missing},
{"lib/mix/tasks/phoenix_kit.modernize_layouts.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.assets.rebuild.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.status.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/email_cleanup.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/email_export.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/email_stats.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/email_test_webhook.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/email_verify_config.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/entities/export.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit/entities/import.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.email.debug_sqs.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.email.process_dlq.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.email.send_test.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.configure_aws_ses.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.process_dlq.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.process_sqs_queue.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.sync_email_status.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.fix_missing_events.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.process_sqs.ex", :callback_info_missing, 1},
{"lib/mix/tasks/phoenix_kit.cleanup_orphaned_files.ex", :callback_info_missing, 1},

# False positive pattern match warnings (runtime behavior differs from static analysis)
{"lib/mix/tasks/phoenix_kit/email_cleanup.ex", :pattern_match, 1},

# Publishing module defensive fallbacks and settings_call dynamic dispatch
{"lib/modules/publishing/publishing.ex", :guard_fail},
{"lib/modules/publishing/publishing.ex", :pattern_match_cov},
{"lib/modules/publishing/publishing.ex", :pattern_match},
{"lib/modules/publishing/shared.ex", :guard_fail},
# ExAws library type definition issues (false positives from incomplete type specs)
~r/lib\/modules\/emails\/archiver\.ex:.*pattern_match/,
~r/lib\/modules\/emails\/archiver\.ex:.*unused_fun/,

# Ecto.Multi opaque type false positives (code works correctly)
~r/lib\/phoenix_kit\/users\/auth\.ex:.*call_without_opaque/,

Expand Down Expand Up @@ -142,5 +105,11 @@
# ExUnit internal functions — false positives when test/support is compiled in MIX_ENV=test
# Dialyzer cannot resolve ExUnit private macros expanded at compile time
{"test/support/conn_case.ex", :unknown_function},
{"test/support/data_case.ex", :unknown_function}
{"test/support/data_case.ex", :unknown_function},

# Sync connections_live - MapSet opaque type false positives in topo_sort/visit_node
# Same pattern as context_selector.ex - MapSet.t() opaque type through recursive functions
# Matches both standard Dialyxir format (call_without_opaque) and legacy format (opaque term)
~r/lib\/modules\/sync\/web\/connections_live\.ex:.*call_without_opaque/,
~r/lib\/modules\/sync\/web\/connections_live\.ex:.*opaque term/
]
242 changes: 0 additions & 242 deletions lib/mix/tasks/phoenix_kit.configure_aws_ses.ex
View file
Open in desktop

This file was deleted.

Loading
Loading