Fix cookie consent, extract billing/shop modules - #453
Merged
Conversation
Merge dev → main: Fix SeedTemplates System.halt
…I toggle - Replace hardcoded cookie/privacy URLs with Routes.path() to fix double-slash bug - Add dynamic legal_links from published pages + single /legal index link - Use bg-base-100/70 backdrop instead of bg-black for light/dark theme compatibility - Improve glass opacity (0.95→0.98), card bg (50→80%), text contrast - Replace custom toggle with standard daisyUI toggle toggle-primary
…rdering
- Replace %Currency{} struct matches with plain variables (cross-package dep)
- Replace %PaymentOption{} struct matches with %{} map patterns
- Move nil clauses before catch-all in format_price/2 functions
- Fix alias ordering for CountryData (Utils.* after Modules.*)
- Cross-package Billing references will resolve when phoenix_kit_billing dep added
- Add Estonian (et) to the default admin panel language list - Fix Chinese language code from zh-CN to zh for consistency (all backend language codes should be two-letter ISO 639-1)
…age) - Delete lib/modules/shop/ (63 files), routes/shop.ex, mix task - Remove Shop from internal_modules in module_registry - Update integration.ex: conditional shop pipeline, safe_route_call for admin routes, Code.ensure_loaded? guards for public/authenticated routes - Update users/auth.ex: guard maybe_merge_guest_cart with ensure_loaded? - Add @compile no_warn_undefined for cross-package Shop references - Add admin_locale_routes to emails routes to avoid alias conflicts - Fix safe_route_call to silently handle :nofile and :unavailable - Add dialyzer ignore for extracted module references in integration.ex
# Conflicts: # .dialyzer_ignore.exs # lib/modules/billing/billing.ex # lib/modules/legal/legal.ex # lib/modules/shop/web/catalog_category.ex # lib/modules/shop/web/catalog_product.ex # lib/modules/sync/web/connections_live.ex # lib/phoenix_kit/module_registry.ex # lib/phoenix_kit_web/components/core/cookie_consent.ex # lib/phoenix_kit_web/integration.ex # lib/phoenix_kit_web/live/modules.html.heex # lib/phoenix_kit_web/routes/emails.ex
timujinne
changed the title
ddon
added a commit
that referenced
this pull request
Mar 27, 2026
…language naming - Add Code.ensure_loaded? guard to delete_user_shop_carts/1 (runtime crash without Shop package) - Add missing legal_links and legal_index_url attrs to root.html.heex consent component - Render legal_links in cookie consent modal footer (attr was declared but never used) - Sync JS consent widget glass opacity (0.95->0.98) and backdrop color (--bc->--b1) to match Elixir component - Rename @top_10_languages to @default_languages (list has 13 items, not 10) - Add PR #453 review documentation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Cookie Consent Fix
toggle toggle-primarycomponentlegal_index_urlto consent widget configBilling Extraction
Shop Extraction
safe_route_callMerge with upstream/dev
Test Plan
mix compile --warnings-as-errorspassesmix formatcleanmix credo --strictno issuesmix dialyzerpasses