Skip to content

Remove Legal module from core (extracted to phoenix_kit_legal) #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddon merged 5 commits into from
Mar 28, 2026
Merged

Remove Legal module from core (extracted to phoenix_kit_legal) #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ba7386
Remove duplicate LayoutWrapper from admin module templates
timujinne Mar 27, 2026
95670f1
Add user dashboard routes for billing profiles
timujinne Mar 27, 2026
1147313
Remove Legal module from core (extracted to phoenix_kit_legal package)
timujinne Mar 27, 2026
cb8028e
Remove LayoutWrapper from remaining storage and maintenance templates
timujinne Mar 27, 2026
bebc2d1
Merge upstream/dev into legal-cookie-consent-fix (resolve delete conf…
timujinne Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .dialyzer_ignore.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,9 @@
# Ecto.Multi opaque type false positives (code works correctly)
~r/lib\/phoenix_kit\/users\/auth\.ex:.*call_without_opaque/,

# Legal module - dynamic dispatch to Publishing module
# Dialyzer can't infer types through publishing_module() helper
~r/lib\/modules\/legal\/legal\.ex:.*pattern_match/,

# ConsentLog schema - changeset type spec with empty struct
~r/lib\/modules\/legal\/schemas\/consent_log\.ex:.*invalid_contract/,
~r/lib\/modules\/legal\/schemas\/consent_log\.ex:.*no_return/,
~r/lib\/modules\/legal\/schemas\/consent_log\.ex:.*call/,
# Legal module (extracted to phoenix_kit_legal) — conditional component calls
{"lib/phoenix_kit_web/components/layout_wrapper.ex", :unknown_function},
{"lib/phoenix_kit_web/components/layouts/root.html.heex", :unknown_function},

# Pages module - type inference false positives
~r/lib\/modules\/pages\/listing_cache\.ex:.*pattern_match/,
Expand Down
728 changes: 360 additions & 368 deletions lib/modules/customer_service/web/details.html.heex
View file
Open in desktop

Large diffs are not rendered by default.

350 changes: 171 additions & 179 deletions lib/modules/customer_service/web/edit.html.heex
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading