Rework Protocol Documentation #927
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be better to also include "Protocol" in the page titles so that if they're embedded somewhere like Discord the link will say "Bedrock Protocol" rather than just "Bedrock". |
|
Got that and your prior suggestion on discord covered! |
QuazChick
reviewed
Oct 21, 2024
Co-authored-by: QuazChick <[email protected]>
docs/servers/raknet.md
Outdated
| | u24 (unsigned int24) | 3 | 0 - 2^24-1 | Unsigned 21-bit integer | | ||
| | i64 (long) | 8 | -2^63 to 2^63-1 | Signed 64-bit integer | | ||
| | bool (boolean) | 1 | 0 - 1 | `0` is `false`, while `1` is `true` | | ||
| | String | N/A | | A String prefixed by a unsigned short which depicts the length | |
There was a problem hiding this comment.
I feel you should note the fact that the strings prefixed length is in Big Endian
There was a problem hiding this comment.
should be covered now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks large chunks of the protocol documentation. Please look over it and give it a few thoughts, I dont think it is finished yet, as some sections are still marked as To be documented.
Thats also why this is a draft right now...