Change ClientInstance Registry insert to insert_or_assign #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows new RosAction-/RosTopic-/RosServiceClients to assign new ClientInstances into the Registry in the event that the old ClientInstance went out of scope.
For example, if a BehaviorTree with three RosServiceNodes to /foo is created, only one ServiceClient is constructed and is then shared between all clients. However, if that tree goes out of scope and destroys its service client, and a new instance is constructed, all three RosServiceNodes construct their own ServiceClient for a total of three service clients. This is because the insert function does not overwrite the expired weakptrs left in the registry.