Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support prefixed types in ClassInjector.SystemTypeFromIl2CppType #153

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support prefixed types in ClassInjector.SystemTypeFromIl2CppType #153

wants to merge 1 commit into from

Conversation

ds5678
Copy link
Collaborator

@ds5678 ds5678 commented Sep 8, 2024

Resolves #135

@ds5678 ds5678 added this to the 1.5.0 milestone Sep 8, 2024
@ds5678 ds5678 requested a review from Kasuromi September 8, 2024 16:22
@js6pak
Copy link
Member

js6pak commented Sep 10, 2024

ClassInjector.RewriteType already tries to tackle the Il2Cpp prefix but only does so for the System.* types. It also only works for types that have a non-prefixed version which no longer has to be the case since #39.
Thinking about it more I think RewriteType is inherently flawed and it should actually just operate on the Il2CppTypeStruct not System.Types.

@ds5678 ds5678 force-pushed the system-type-from-il2cpp-type-fix branch 2 times, most recently from 4841da9 to 89e48dc Compare September 14, 2024 16:24
@js6pak js6pak marked this pull request as draft September 14, 2024 17:51
@ds5678 ds5678 force-pushed the system-type-from-il2cpp-type-fix branch from 89e48dc to 22611e8 Compare September 14, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kasuromi Kasuromi Awaiting requested review from Kasuromi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
injection
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

ClassInjector.SystemTypeFromIl2CppType fails when types are prefixed.
2 participants
@ds5678 @js6pak