Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Invalid Generic Parameter Names #154

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Fix Invalid Generic Parameter Names #154

merged 1 commit into from
Sep 14, 2024

Conversation

ds5678
Copy link
Collaborator

@ds5678 ds5678 commented Sep 8, 2024

Resolves #130
Closes #131

@ds5678 ds5678 added the generation Related to assembly generation label Sep 8, 2024
@ds5678 ds5678 added this to the 1.5.0 milestone Sep 8, 2024
@ds5678 ds5678 requested a review from js6pak September 8, 2024 16:50
@ds5678 ds5678 mentioned this pull request Sep 8, 2024
Open
@ds5678 ds5678 force-pushed the fix-invalid-generic-parameter-names branch from 583fe08 to 7cddab8 Compare September 13, 2024 22:28
@ds5678 ds5678 force-pushed the fix-invalid-generic-parameter-names branch from 7cddab8 to 847f46e Compare September 14, 2024 16:23
js6pak
js6pak requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@js6pak js6pak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just do new GenericParameter(oldParameter.Name.FilterInvalidInSourceChars()); directly?

@ds5678
Copy link
Collaborator Author

ds5678 commented Sep 14, 2024

Can't we just do new GenericParameter(oldParameter.Name.FilterInvalidInSourceChars()); directly?

That method allocates a new string, so we only want to use it if we have to.

@ds5678 ds5678 merged commit 23b74e1 into BepInEx:master Sep 14, 2024
2 checks passed
@ds5678 ds5678 deleted the fix-invalid-generic-parameter-names branch September 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js6pak js6pak js6pak approved these changes

Assignees
No one assigned
Labels
generation Related to assembly generation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Rewired: non-valid Unicode characters in generic parameter name
2 participants
@ds5678 @js6pak