Port UnhollowerPdbGen to Il2CppInterop #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds5678
force-pushed
the
pdb-generator
branch
4 times, most recently
from
291bc7b
to
a2c57b1
Compare
|
The general consensus when we picked the project up was to remove the pdb generation as it was deemed useless and used a proprietary windows only pdb library. I believe we were expecting Cpp2IL to deal with the pdb generation for us at one point or another. We can carry over the discussion on whether or not this feature is necessary for the time being on discord. Relevant discord messages: here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original source: https://github.com/knah/Il2CppAssemblyUnhollower/tree/ea4ff499b2bd902de8ef2de3d132278cbb86ae4f/UnhollowerPdbGen
Modifications:
Il2CppInterop.Commoninstead ofUnhollowerBaseLibAsmResolverinstead ofMono.CecilResolves #105