fix: return 404 instead of 500 for non-existent team in permissions_update #16827
+139
−84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return 404 instead of 500 for non-existent team in permissions_update
Relevant issues
Fixes #16814
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🐛 Bug Fix
Changes
The
/team/permissions_updateendpoint was throwing an unhandled exception whenget_team_objectfailed to find a team (raising a genericException), resulting in a 500 Internal Server Error.Changes made:
litellm/proxy/management_endpoints/team_endpoints.py: Wrapped theget_team_objectcall in atry/exceptblock. It now catches the exception and raises a properHTTPException(status_code=404)if the team is not found, consistent with other team endpoints.test_update_team_permissions_fail_team_not_foundtotests/test_litellm/proxy/management_endpoints/test_team_endpoints.pyto verify that a non-existent team ID returns a 404 status code instead of crashing.