CI/CD improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the namespace structure across the NinjaOne Client SDK, transitioning from NinjaOne.Client.V2 to NinjaOne.Client.NinjaRmm.V2. The changes are part of CI/CD improvements and involve updating namespace declarations and type references throughout the V2 Device API models.
Key Changes:
- Namespace refactoring from
NinjaOne.Client.V2.Device.ItemtoNinjaOne.Client.NinjaRmm.V2.Device.Item - Addition of new model classes for device references, alerts, activities, and custom fields
- Updates to all XML documentation references to reflect the new namespace structure
Reviewed changes
Copilot reviewed 254 out of 3187 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DeviceGetResponse_userData.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_warranty.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_role_nodeClass.cs | Updated namespace declaration |
| DeviceGetResponse_references_role_fields.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_role_chassisType.cs | Updated namespace declaration |
| DeviceGetResponse_references_rolePolicy_nodeClass.cs | Updated namespace declaration |
| DeviceGetResponse_references_rolePolicy_fields.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_rolePolicy.cs | Added new model class with updated namespace |
| DeviceGetResponse_references_role.cs | Added new model class with updated namespace |
| DeviceGetResponse_references_policy_nodeClass.cs | Updated namespace declaration |
| DeviceGetResponse_references_policy_fields.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_policy.cs | Added new model class with updated namespace |
| DeviceGetResponse_references_organization_*.cs | Updated namespace and documentation references across organization-related models |
| DeviceGetResponse_references_location_*.cs | Updated namespace and documentation references across location-related models |
| DeviceGetResponse_references_backupUsage.cs | Updated namespace and documentation references |
| DeviceGetResponse_references_backupBandwidthThrottle_*.cs | Updated namespace and documentation references across backup bandwidth throttle models |
| DeviceGetResponse_references_assignedOwner_*.cs | Updated namespace and documentation references across assigned owner models |
| DeviceGetResponse_references.cs | Added new model class with updated namespace |
| DeviceGetResponse_notes.cs | Updated namespace and documentation references |
| DeviceGetResponse_nodeClass.cs | Updated namespace declaration |
| DeviceGetResponse_maintenance_*.cs | Updated namespace and documentation references across maintenance models |
| DeviceGetResponse_fields.cs | Updated namespace and documentation references |
| DeviceGetResponse_approvalStatus.cs | Updated namespace declaration |
| DeviceGetResponse.cs | Added new model class with updated namespace |
| DashboardUrl/DashboardUrlRequestBuilder.cs | Added new request builder with updated namespace |
| DashboardUrl/DashboardUrl5XXError.cs | Updated namespace and documentation references |
| DashboardUrl/DashboardUrl4XXError.cs | Updated namespace and documentation references |
| CustomFields/CustomFieldsRequestBuilder.cs | Added new request builder with updated namespace |
| CustomFields/CustomFieldsPatchRequestBody.cs | Added new model class with updated namespace |
| CustomFields/CustomFields5XXError.cs | Added new error model class with updated namespace |
| CustomFields/CustomFields4XXError.cs | Added new error model class with updated namespace |
| Alerts/Alerts_*.cs | Added new alert-related model classes with updated namespace |
| Activities/Activities5XXError_activities_*.cs | Added new activity-related enum classes with updated namespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changed the publish step in nuget_publish.yml to push packages from bin/Release instead of NinjaOne.Client/bin/Release, allowing packages from any project in the release directory to be published. ops(ci): publish all .nupkg files from bin/Release update nuget_publish.yml to push packages from both NinjaOne.Client/bin/Release and bin/Release, ensuring all relevant NuGet packages are published regardless of subdirectory location
replace placeholder README with comprehensive documentation for the NinjaOne Client SDK for .NET, including installation, authentication, usage examples, configuration, regeneration instructions, CI/CD workflow, contributing guidelines, troubleshooting, and license details to improve developer onboarding and usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.