Repository navigation
Initialize VecWriter with empty memory, and add take! - #66
Merged
Merged
Conversation
Two changes: First, initialize VecWriter with an empty memory, to defer its backing allocation until the first write. Some workarounds have to be done to ensure that the allocation remains a StringVector after reallocations. The cost is an extra branch in the cold outlined allocation path. Second, add `take!`, which may be useful when using StringView.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 96.81% 96.86% +0.04%
==========================================
Files 13 13
Lines 1100 1117 +17
==========================================
+ Hits 1065 1082 +17
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
First, initialize VecWriter with an empty memory, to defer its backing allocation until the first write. Some workarounds have to be done to ensure that the allocation remains a StringVector after reallocations. The cost is an extra branch in the cold outlined allocation path.
Second, add
take!, which may be useful when using StringView.