Skip to content

Initialize VecWriter with empty memory, and add take! - #66

Merged
jakobnissen merged 1 commit into
masterfrom
vecwriter
Nov 13, 2026
Merged

jakobnissen merged 1 commit into
masterfrom
vecwriter

Conversation

@jakobnissen

Copy link
Copy Markdown
Member

Two changes:
First, initialize VecWriter with an empty memory, to defer its backing allocation until the first write. Some workarounds have to be done to ensure that the allocation remains a StringVector after reallocations. The cost is an extra branch in the cold outlined allocation path.

Second, add take!, which may be useful when using StringView.

Two changes:
First, initialize VecWriter with an empty memory, to defer its backing
allocation until the first write. Some workarounds have to be done to
ensure that the allocation remains a StringVector after reallocations.
The cost is an extra branch in the cold outlined allocation path.

Second, add `take!`, which may be useful when using StringView.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (2bf78b7) to head (5d2d535).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   96.81%   96.86%   +0.04%     
==========================================
  Files          13       13              
  Lines        1100     1117      +17     
==========================================
+ Hits         1065     1082      +17     
  Misses         35       35              
Flag Coverage Δ
unittests 96.86% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakobnissen jakobnissen mentioned this pull request Nov 13, 2026
@jakobnissen
jakobnissen merged commit 89afed1 into master Nov 13, 2026
8 checks passed
@jakobnissen
jakobnissen deleted the vecwriter branch November 13, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants