Add ChangePassword API method #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested changes
Nov 20, 2025
| return nil | ||
| } | ||
|
|
||
| func (device *Device) ChangePassword() error { |
api/firmware/system_test.go
Outdated
| func TestSimulatorChangePassword(t *testing.T) { | ||
| testInitializedSimulators(t, func(t *testing.T, device *Device, stdOut *bytes.Buffer) { | ||
| t.Helper() | ||
| require.NoError(t, device.ChangePassword()) |
Contributor
There was a problem hiding this comment.
This will fail on simulators <v9.25, so something like this will be needed:
bitbox02-api-go/api/firmware/btc_test.go
Lines 802 to 812 in c2ba9af
Add support for changing the device password on an initialized BitBox02. Changes: - Add ChangePasswordRequest protobuf message to bitbox02_system.proto - Add change_password field to Request oneof in hww.proto - Implement ChangePassword() method in system.go - Add firmware version check (requires v9.25.0+) - Add status validation (device must be StatusInitialized) - Add TestSimulatorChangePassword test coverage - Regenerate protobuf Go files The ChangePassword() method validates device state and firmware version before initiating the password change workflow on the device.
cedwies
force-pushed
the
cedwies/change-password
branch
from
c0a17a6 to
8d2cb78
Compare
benma
approved these changes
Nov 22, 2025
Contributor
benma
left a comment
benma
left a comment
There was a problem hiding this comment.
utACK, nice! Please merge 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for changing the device password on an initialized BitBox02.
Changes:
The ChangePassword() method validates device state and firmware version before initiating the password change workflow on the device.