src/ui/components: Added -Feature: Hitting back during "keypad" input goes back to previous group of characters #862- #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input goes back to previous group of characters BitBoxSwiss#862-
Collaborator
|
Tested, but I think I found an edge case. See the recording. It seems to jump back "two navigations" when I go back and forward. edit: please use clang-format to format as well. I noticed CI failed on formatting. Screen.Recording.2025-11-17.at.15.30.22.mov |
Author
|
Thank you for your feedback, I will definitely try to figure out what is wrong, will use clang-format as well 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I gave issue #862 a try.
I tested it by building in the container and using the graphical simulator, and it seems that now pressing the back button takes you to the previous group instead of all letters.
Unfortunately, I haven’t had a physical device yet, so I haven’t been able to try flashing it.
Would love your feedback! Thanks