-
Notifications
You must be signed in to change notification settings - Fork 299
feat: added opBNB support #7731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
406a9d3 to
f01a689
Compare
|
@claude review this pr as grug. Only focus on bugs and issues, I do not care about things that are done well, exclude these from your output. Limit your output to 500 words or less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for opBNB, a Layer 2 blockchain built on the OP Stack (Optimism infrastructure) and maintained by BNB Chain. The implementation follows the pattern used for other Ethereum-compatible chains by adding the necessary coin family definitions, network configurations, environment settings, and factory registrations for both mainnet ('opbnb') and testnet ('topbnb').
Key changes:
- Added opBNB to the CoinFamily and UnderlyingAsset enums
- Created OpBNB and OpBNBTestnet network class definitions with appropriate chain IDs (204 for mainnet, 5611 for testnet)
- Registered opBNB coins in the factory as EthLikeCoin instances with corresponding test fixtures
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/statics/src/base.ts | Added OPBNB to CoinFamily and UnderlyingAsset enums |
| modules/statics/src/networks.ts | Defined OpBNB and OpBNBTestnet network classes with explorer URLs and chain IDs, exported in Networks object |
| modules/statics/src/allCoinsAndTokens.ts | Created coin definitions for topbnb (testnet) and opbnb (mainnet) with features and network references |
| modules/sdk-core/src/bitgo/environments.ts | Added environment configurations for opbnb and topbnb with API baseUrl and token settings |
| modules/bitgo/src/v2/coinFactory.ts | Registered opbnb/topbnb in coin factory and token constructor mappings |
| modules/statics/test/unit/fixtures/expectedColdFeatures.ts | Added opbnb and topbnb to the 'neither' category (no TSS or multisig support) |
| modules/sdk-coin-ethlike/test/unit/ethlikeCoin.ts | Added topbnb to the test suite for EthLikeCoin functionality |
| modules/sdk-coin-ethlike/test/fixtures/ethlikeCoin.ts | Added test fixtures including transaction hex and custodial hot wallet signature data for topbnb |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ticket: COIN-6014
TICKET: COIN-6014