Test transactions while sending #1182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first-pass text and mocks are added
✅ Deploy Preview for bitcoin-design-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sending guide to introduce a new "Test transactions" section that explains how users can send small test payments to verify large or unfamiliar transactions.
- Added a new images block ("imagesTestTransactions") including four image entries.
- Included a detailed "Test transactions" section outlining the interaction flow for test transactions.
Comments suppressed due to low confidence (1)
guide/daily-spending-wallet/sending.md:271
- [nitpick] Consider revising this statement for clarity. For example, change it to 'application presents this option to the user on the review screen' and adjust the conditional clause for improved readability.
1. **application presents this option user on review screen**: in the appropriate scenario, such as large amount or new silent payments address is being used.
Comment on lines
+141
to
+153
| alt: Wallet home screen with amount input, pay and request options | ||
| caption: Home screens provide quick access to entering payment flows. | ||
| - file: send-test-transaction-confirmation | ||
| modalImage: send-test-transaction-confirmation-big | ||
| alt: Wallet home screen with amount input, pay and request options | ||
| caption: Home screens provide quick access to entering payment flows. | ||
| - file: home-test-transaction-reminder | ||
| modalImage: home-test-transaction-reminder-big | ||
| alt: Wallet home screen with amount input, pay and request options | ||
| caption: Home screens provide quick access to entering payment flows. | ||
| - file: finalise-test-transaction | ||
| modalImage: finalise-test-transaction-big | ||
| alt: Wallet home screen with amount input, pay and request options |
There was a problem hiding this comment.
[nitpick] The alt text for multiple images in the test transactions block is identical, which could hinder accessibility. Consider providing unique, descriptive alt texts for each image to better convey their distinct content.
Suggested change
| alt: Wallet home screen with amount input, pay and request options | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: send-test-transaction-confirmation | |
| modalImage: send-test-transaction-confirmation-big | |
| alt: Wallet home screen with amount input, pay and request options | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: home-test-transaction-reminder | |
| modalImage: home-test-transaction-reminder-big | |
| alt: Wallet home screen with amount input, pay and request options | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: finalise-test-transaction | |
| modalImage: finalise-test-transaction-big | |
| alt: Wallet home screen with amount input, pay and request options | |
| alt: Review screen showing a toggle to enable test transactions | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: send-test-transaction-confirmation | |
| modalImage: send-test-transaction-confirmation-big | |
| alt: Confirmation screen for sending a test transaction | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: home-test-transaction-reminder | |
| modalImage: home-test-transaction-reminder-big | |
| alt: Reminder on the home screen about an ongoing test transaction | |
| caption: Home screens provide quick access to entering payment flows. | |
| - file: finalise-test-transaction | |
| modalImage: finalise-test-transaction-big | |
| alt: Finalization screen for completing a test transaction |
Copilot uses AI. Check for mistakes.
| @@ -241,6 +259,21 @@ If using a security step here, it should come after the user has selected all ot | |||
|
|
|||
| {% include image-gallery.html pages = page.imagesReview %} | |||
|
|
|||
| ### Test transactions | |||
There was a problem hiding this comment.
I notice this section isn't showing up in the table of contents on the preview. Could we fix that?
| Technically, this feature can utilise [replace-by-fee](https://bitcoinops.org/en/topics/replace-by-fee/) (RBF) or a simple small-value transaction. | ||
|
|
||
| There are three main interactions in this feature: | ||
| 1. **application presents this option user on review screen**: in the appropriate scenario, such as large amount or new silent payments address is being used. |
There was a problem hiding this comment.
Capitalize the A in application.
|
|
||
| There are three main interactions in this feature: | ||
| 1. **application presents this option user on review screen**: in the appropriate scenario, such as large amount or new silent payments address is being used. | ||
| 2. **user chooses & sends the test transaction**: they may ignore it if they have no way of communicating with the receiver. Inform users about relevant fees, if any. |
There was a problem hiding this comment.
- User chooses & sends the test transaction: they may ignore it if they have no way of communicating with the receiver. Inform users about relevant fees, if any.
| There are three main interactions in this feature: | ||
| 1. **application presents this option user on review screen**: in the appropriate scenario, such as large amount or new silent payments address is being used. | ||
| 2. **user chooses & sends the test transaction**: they may ignore it if they have no way of communicating with the receiver. Inform users about relevant fees, if any. | ||
| 3. **user finalises the original payment**: allow the user to easily find and finalise the transaction. Applications can even remind the user about this after appropriate time. |
There was a problem hiding this comment.
- User finalises the original payment: allow the user to easily find and finalise the transaction. Applications can even remind the user about this after appropriate time.
| Technically, this feature can utilise [replace-by-fee](https://bitcoinops.org/en/topics/replace-by-fee/) (RBF) or a simple small-value transaction. | ||
|
|
||
| There are three main interactions in this feature: | ||
| 1. **application presents this option user on review screen**: in the appropriate scenario, such as large amount or new silent payments address is being used. |
There was a problem hiding this comment.
- Application presents this option user on review screen: in the appropriate scenario, such as large amount or new silent payments address is being used.
|
I left a few minor comments. On the whole I'm not sure how I feel about this addition. I think test transactions are very useful and I usually do them when I'm getting familiar with a new wallet, but I'm conflicted about encouraging wallets to add this into their flow. If we follow the KISS (Keep It Simple Stupid) principle it seems like this adds extra complexity. I know it's an optional feature, and that's emphasized in the copy, so maybe that's enough. Just my 2 sats on this. |
|
Really good Lopp thread on test transaction dropped this weekend. Some food for thought on this practice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1106
🕵️♂️🔎 Preview 🔍🕵️♀️