Add Civ Lite combat feedback#66
Merged
Merged
Conversation
Contributor
Author
|
CI note: SonarCloud passed with 0 new issues. The only red check is the existing Godot Web export preset configuration failure ( Local validation completed:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #23.
Summary
Validation
find demo/civ-lite -name '*.test.mjs' -print | sort | xargs node --test\n-node --check demo/civ-lite/feedback-model.js && node --check demo/civ-lite/game.js && node --check demo/civ-lite/sprites.js\n-git diff --check\n- Chrome/Playwright smoke againstdemo/civ-lite/index.html: canvas rendered nonblank, no page errors, all app resources loaded