You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pushed a focused test-hardening follow-up (bdf07c8) for the entrypoint regression.
Added coverage that explicit commands still pass through unchanged while -flag and *.conf invocations are rewritten to bgl_oneshot. This tightens the proof that the fix only restores the intended default-command behavior and does not hijack custom container commands.
Maintainer-facing review-assist for the Bitgesell #81/#39 bounty lane:
I checked this as a BGL ARM Docker entrypoint/runtime fix. The useful part is that it removes the stale btc_oneshot guard and makes the default-command rewrite use bgl_oneshot, while adding regression coverage for the two default startup forms and custom-command passthrough.
Acceptance checks I would use before landing:
bash test/tests/entrypoint.sh should pass from the repo root and prove -flag and *.conf invocations rewrite to bgl_oneshot.
The explicit command passthrough case should remain unchanged, so container users can still run custom commands without being redirected into the node entrypoint.
The added command -v gosu and id BGL checks should be acceptable as fail-open behavior when a derived image lacks gosu or the BGL user; if maintainers expect hard failure instead, that policy should be stated before merge.
The test path is test/tests/entrypoint.sh; if the repo has an intended aggregate test runner, wiring this script into it would make the regression harder to miss.
I did not run local Docker or shell tests in this triage pass; this note is based on the visible diff and PR metadata only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.confinvocations are rewritten tobgl_oneshotinstead of the non-existentbglcommandVerification
bash test/tests/entrypoint.shgit diff --check origin/main..HEADBounty
Submitted for Bitgesell improvement bounty consideration: BitgesellOfficial/bitgesell#81 and BitgesellOfficial/bitgesell#39.
Payout address, if approved:
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428Executor revalidation (20260618T184217Z)
Fresh payout-readiness check after the review-assist note on this PR:
tolga-tom-nook, mergeable/clean, not draft.bdf07c876f48455b6c09a05fcb3c005572a9fe8f.git rev-list --left-right --count origin/main...HEAD->0 2.bash test/tests/entrypoint.shpassed.git diff --check origin/main...HEADpassed.This remains a focused entrypoint/default-command guard fix for the Bitgesell bounty lane; no runtime scope expansion or payout change.