fix: explain missing Brotli submodule during build - #1
Open
manuelsampedro1 wants to merge 1 commit into
Open
Conversation
|
Review assist for maintainers: This looks like a focused build-diagnostics improvement for git-checkout users who have not initialized the bundled Brotli C submodule. I checked the patch scope: README adds the exact Suggested merge checks:
I do not see dependency, runtime compression, wallet/key, or live-node behavior changes in this patch as written; the main acceptance criterion is clearer failure mode coverage for source checkouts missing Brotli C sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the failure mode for git checkouts that have not initialized the bundled Brotli C submodule.
A clean checkout without submodules currently fails deep inside cc/clang:
Changes:
git submodule update --init --recursiveValidation:
git submodule update --init --recursivecargo testBounty context: BitgesellOfficial/bitgesell#39