fix: restore go toolkit build - #1
Open
Luzijano wants to merge 1 commit into
Open
Conversation
Signed-off-by: Lucijano JL. <218673409+Luzijano@users.noreply.github.com>
|
Review assist for maintainers: This is a broader build-restoration patch: it normalizes the Go directive, removes duplicate SDKConfig definitions, fixes the checked-in example import/constructor usage, restores missing interface/type definitions, and starts decoding address API responses instead of returning empty structs. Suggested merge checks:
I do not see wallet/key, signing, broadcast, live RPC, or live-chain behavior changes in this patch as written; the acceptance criterion is that the toolkit compiles/tests from a clean checkout without unintentionally changing SDK error/API compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.modso the module uses a CI-compatible Go directive (1.20instead of patch-form1.21.6)SDKConfigdeclarations and the undefinedobject/ misspelled Merkle proof types that prevented package compilationgo test ./...also compiles the example packageValidation
go test ./...failed immediately on the invalid Go directive, then exposed compile errors after the directive was correctedgo test ./...git diff --checkBounty / improvement program
Submitted as a small build/test reliability improvement under BitgesellOfficial/bitgesell#81.
Assisted by Hermes Agent.