fix: use bitgesell-core debug namespace - #2
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default debug logger namespace used by the client and adds a test to ensure this default remains correct.
Changes:
- Change default
debugnyannamespace frombitcoin-coretobitgesell-core. - Add a regression test that asserts the default logger namespace.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/default_logger_test.js | Adds a test that monkey-patches debugnyan to capture and assert the namespace. |
| src/index.js | Updates the default logger namespace string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| delete require.cache[clientPath]; | ||
| require.cache[debugnyanPath].exports = name => { |
|
Maintainer triage for the Bitgesell bounty queue (#39): this looks like a narrow, relevant Bitgesell-branding fix rather than a broad dependency or generated-file change. What I verified from the PR diff:
Recommended maintainer acceptance checks before merge:
I did not run the package locally in this pass, and I am not making a payout claim from this review note. |
Summary
bitcoin-coretobitgesell-coredebugnyanand verifies the default namespaceWhy
The package name, README logging examples, and Bitgesell fork branding use
bitgesell-core, but the default constructor still initializeddebugnyan('bitcoin-core'). That makes users enabling DEBUG logs with the documentedbitgesell-corenamespace miss default client logs.Validation
npm install --ignore-scripts(regularnpm installcurrently triggers the existingdependencieslifecycle script and fails without docker-compose config; this is already covered separately by PR fix: avoid npm install lifecycle conflict #1)npx mocha test/default_logger_test.js test/logging/request-obfuscator_test.js --require shouldnpx eslint src/index.js test/default_logger_test.jsgit diff --checkNote: the full pre-commit hook runs
eslint src testand fails in this Windows checkout because many untouched repository files are checked out with CRLF while the legacy lint rule requires LF. The targeted changed files pass ESLint after autofix.Refs BitgesellOfficial/bitgesell#39. Payout details can be provided privately if maintainers consider this eligible under the bounty program.