test: keep legacy config aliases on Bitgesell services - #3
Open
tolga-tom-nook wants to merge 1 commit into
Open
Conversation
This was referenced May 25, 2026
|
Review assist for maintainers: This is a narrow compatibility/testability patch: the inherited Suggested merge checks:
I do not see wallet/key, signing, RPC daemon, live node, or chain behavior changes in this patch as written; the acceptance criterion is that legacy config aliases resolve to the intended Bitgesell config objects and stay covered by regression tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.bitcoin*aliases to the Bitgesell service configs so legacy tests and consumers reference the same Bitgesell config objects.Validation
./node_modules/.bin/eslint src test --quietnpm test -- --grep 'Configuration aliases'git diff --checkBounty note
Submitting for the Bitgesell improvement/PR bounty program tracked in BitgesellOfficial/bitgesell#81 and related BitgesellOfficial/bitgesell#39. Payout address if approved: EVM/USDT-compatible
0x4a76c7E64C08cF29B59eFC640b4ada97A270d428.