Skip to content

test: keep legacy config aliases on Bitgesell services - #3

Open
tolga-tom-nook wants to merge 1 commit into
BitgesellOfficial:mainfrom
tolga-tom-nook:bounty/js-bitgesellcore-rpc-config-aliases
Open

test: keep legacy config aliases on Bitgesell services#3
tolga-tom-nook wants to merge 1 commit into
BitgesellOfficial:mainfrom
tolga-tom-nook:bounty/js-bitgesellcore-rpc-config-aliases

Conversation

@tolga-tom-nook

Copy link
Copy Markdown

Summary

  • Restores the inherited config.bitcoin* aliases to the Bitgesell service configs so legacy tests and consumers reference the same Bitgesell config objects.
  • Extracts shared Bitgesell service config constants to prevent alias drift.
  • Adds a no-daemon regression test for alias identity and normalizes the package-lock root metadata to the Bitgesell package identity.

Validation

  • ./node_modules/.bin/eslint src test --quiet
  • npm test -- --grep 'Configuration aliases'
  • git diff --check

Bounty note

Submitting for the Bitgesell improvement/PR bounty program tracked in BitgesellOfficial/bitgesell#81 and related BitgesellOfficial/bitgesell#39. Payout address if approved: EVM/USDT-compatible 0x4a76c7E64C08cF29B59eFC640b4ada97A270d428.

@MyTH-zyxeon

Copy link
Copy Markdown

Review assist for maintainers:

This is a narrow compatibility/testability patch: the inherited config.bitcoin* names now point at the same Bitgesell service config objects instead of disappearing while the upstream bitcoin-core test suite is migrated. The new alias test asserts object identity for bitcoin, bitcoinMultiWallet, bitcoinSsl, and bitcoinUsernameOnly, so future config drift should be caught without needing a daemon.

Suggested merge checks:

  • Run npm install --legacy-peer-deps, the focused npm test -- --grep 'Configuration aliases', and the repo's normal lint/test target.
  • Confirm this is intentionally a compatibility bridge only: runtime exports should remain Bitgesell-first, while legacy test/consumer names keep working during migration.
  • Verify the package-lock.json root name/version normalization matches package.json; if package metadata is handled in a separate PR, avoid merge-order drift.
  • Search for other inherited bitcoin* test config references so this alias set is complete enough for the current suite.

I do not see wallet/key, signing, RPC daemon, live node, or chain behavior changes in this patch as written; the acceptance criterion is that legacy config aliases resolve to the intended Bitgesell config objects and stay covered by regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants